Forbid native TypeScript collection types #5598
Open
+63
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
margaretjgu
commented
Oct 31, 2025
| `type MyReq = Required<string>`, | ||
| `type MyPick Pick<integer,"something">`, | ||
| `type MyOmit = Omit<Record, "something">`, | ||
| `type MyDict = Dictionary<string, object>`, |
There was a problem hiding this comment.
The original test file had a bug...it included native types like Record, Partial, etc. in BOTH the valid and invalid arrays. This was contradictory and causing test failures.
I corrected the tests to properly reflect the rule's intent:
valid: Now uses spec-defined aliases (Dictionary) and allowed types (arrays, custom classes)invalid: Contains native utility types (Record,Partial, etc.) and collection types (Map,Set, etc.)
also added test coverage for the new collection types (Map, Set, WeakMap, WeakSet).
margaretjgu
requested review from
Anaethelion,
flobernd,
l-trotta,
picandocodigo and
pquentin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4538