-
Notifications
You must be signed in to change notification settings - Fork 115
Fix reindex-from-remote source host constraints and availability #5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The reindex documentation previously referenced the node setting needed to whitelist remote hosts. This does not apply to serverless. This change clarifies this, and documents the hosts allowed in serverless.
|
Skipping backport as the change only really affects serverless. |
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
Hoping to get this reviewed and ready to review once the change goes live. |
samxbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I assume this doc change will be merged after the whitelist setting is added for production.
Yeah, exactly. |
pete-naylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PeteGillinElastic - I think it is good to go!
The reindex documentation previously referenced the node setting needed to whitelist remote hosts. This does not apply to serverless. This change clarifies this, and documents the hosts allowed in serverless.
Also, reindex-from-remote will be a tech preview in serverless, so this annotates it as such. (The fact that it was previously not available at all in serverless appears not to have been reflected in the spec.)