-
Notifications
You must be signed in to change notification settings - Fork 115
chore: add eslint rule no-all-string-literal-unions to disallow all string literal unions
#5653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… string literal unions
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
flobernd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very good work 🙂
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.1 9.1
# Navigate to the new working tree
cd .worktrees/backport-9.1
# Create a new branch
git switch --create backport-5653-to-9.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b1648774772ec3b492b6d9d0decd165f3596d093
# Push it to GitHub
git push --set-upstream origin backport-5653-to-9.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.1Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.2 9.2
# Navigate to the new working tree
cd .worktrees/backport-9.2
# Create a new branch
git switch --create backport-5653-to-9.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b1648774772ec3b492b6d9d0decd165f3596d093
# Push it to GitHub
git push --set-upstream origin backport-5653-to-9.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.2Then, create a pull request where the |
… string literal unions (#5653) * chore: add eslint rule `no-all-string-literal-unions` to disallow all string literal unions * chore: update README to include `no-all-string-literal-unions` rule description
… string literal unions (#5653) * chore: add eslint rule `no-all-string-literal-unions` to disallow all string literal unions * chore: update README to include `no-all-string-literal-unions` rule description
* chore: add eslint rule `no-all-string-literal-unions` to disallow all string literal unions (#5653) * chore: add eslint rule `no-all-string-literal-unions` to disallow all string literal unions * chore: update README to include `no-all-string-literal-unions` rule description * fix merge
* chore: add eslint rule `no-all-string-literal-unions` to disallow all string literal unions (#5653) * chore: add eslint rule `no-all-string-literal-unions` to disallow all string literal unions * chore: update README to include `no-all-string-literal-unions` rule description * fix merge
Adds an eslint rule to prevent all string literal unions, and suggests an enum instead
Closes: #2365