Update specs for ES|QL include_execution_metadata #5655
Conversation
luigidellaquila
added
the
skip-backport
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
compiler/package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/@types/node/-/node-22.15.31.tgz", | ||
| "integrity": "sha512-jnVe5ULKl6tijxUhvQeNbQG/84fHfg+yMak02cT8QVhBx/F05rAVxCGBYYTh2EKz22D6JF5ktXuNwdx7b9iEGw==", | ||
| "license": "MIT", | ||
| "peer": true, |
There was a problem hiding this comment.
This seems unrelated to include_execution_metadata.
Could you please confirm this is intended?
There was a problem hiding this comment.
I have no idea what it does, it was generated by make contrib.
@pquentin can you confirm that it's expected?
There was a problem hiding this comment.
Good catch. Might be related to the local NPM version.
Since you didn't change anything on the JS tooling itself, we should probably remove all the package-lock changes from this PR to be on the safe side.
There was a problem hiding this comment.
Done, thanks!
There was a problem hiding this comment.
@pquentin can you confirm that it's expected?
As long as CI passes, I don't think that was harmful! We often have small random changes like this that don't make any difference in practice.
idegtiarenko
left a comment
idegtiarenko
left a comment
There was a problem hiding this comment.
Changes around include_execution_metadata looks good to me 👍
|
Thank you for the contribution! Appreciate it. |
Updating ES|QL spec after changes introduced with elastic/elasticsearch#137641