Skip to content

Conversation

@bpintea
Copy link
Collaborator

@bpintea bpintea commented Feb 19, 2020

This PR (belatedly) enables advertising the TIME literals support, corresponding
to the previously added TIME SQL type in Elasticsearch/SQL.

It also fixes a typo and rephrases the text of a couple of tooltips.

The PR also reverts an integration test app incorrect change that
alters the destination variable of a couple of options.

This commit enables advertising the TIME literals support.

It also fixes a typo and rephrases the text of a couple of tooltips.

The commit also reverts an integration test app incorrect change that
alters the destination variable of a couple of options.
Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 2c56a2f into elastic:master Feb 20, 2020
@bpintea bpintea deleted the fix/adverise_time_type_support branch February 20, 2020 12:54
bpintea added a commit that referenced this pull request Feb 20, 2020
This commit enables advertising the TIME literals support.

It also fixes a typo and rephrases the text of a couple of tooltips.

The commit also reverts an integration test app incorrect change that
alters the destination variable of a couple of options.

(cherry picked from commit 2c56a2f)
bpintea added a commit that referenced this pull request Feb 20, 2020
This commit enables advertising the TIME literals support.

It also fixes a typo and rephrases the text of a couple of tooltips.

The commit also reverts an integration test app incorrect change that
alters the destination variable of a couple of options.

(cherry picked from commit 2c56a2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants