[CI] HealthNodeUpgradeIT testHealthNode {upgradedNodes=0} failing

[mark-vieira]

Newly added test in #106902 and reproducibly fails.

Build scan:
https://gradle-enterprise.elastic.co/s/gg4ghkoj262qa/tests/:qa:rolling-upgrade:v8.6.2%23bwcTest/org.elasticsearch.upgrades.HealthNodeUpgradeIT/testHealthNode%20%7BupgradedNodes=0%7D

Reproduction line:

./gradlew ':qa:rolling-upgrade:v8.6.2#bwcTest' -Dtests.class="org.elasticsearch.upgrades.HealthNodeUpgradeIT" -Dtests.method="testHealthNode {upgradedNodes=0}" -Dtests.seed=6A695658DCDEFE8A -Dtests.bwc=true -Dtests.locale=ar-BH -Dtests.timezone=Asia/Makassar -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
Yes

Failure history:
Failure dashboard for org.elasticsearch.upgrades.HealthNodeUpgradeIT#testHealthNode {upgradedNodes=0}

Failure excerpt:

org.elasticsearch.client.ResponseException: method [GET], host [http://[::1]:46403], URI [_health_report], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"invalid_index_name_exception","reason":"Invalid index name [_health_report], must not start with '_'.","index_uuid":"_na_","index":"_health_report"}],"type":"invalid_index_name_exception","reason":"Invalid index name [_health_report], must not start with '_'.","index_uuid":"_na_","index":"_health_report"},"status":400}

  at __randomizedtesting.SeedInfo.seed([6A695658DCDEFE8A:39852990EE53BDA3]:0)
  at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:351)
  at org.elasticsearch.client.RestClient.performRequest(RestClient.java:317)
  at org.elasticsearch.client.RestClient.performRequest(RestClient.java:292)
  at org.elasticsearch.upgrades.HealthNodeUpgradeIT.lambda$testHealthNode$1(HealthNodeUpgradeIT.java:37)
  at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1262)
  at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:1247)
  at org.elasticsearch.upgrades.HealthNodeUpgradeIT.testHealthNode(HealthNodeUpgradeIT.java:36)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.elasticsearch.test.cluster.local.DefaultLocalElasticsearchCluster$1.evaluate(DefaultLocalElasticsearchCluster.java:47)
  at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1570)

[mark-vieira]

@gmarouli since you recently added this test perhaps you can take a look?

[elasticsearchmachine]

Pinging @elastic/es-data-management (Team:Data Management)

[nielsbauman]

It looks like it's failing because the health_report API doesn't exist, which in turn is probably caused by the test running on a version that didn't contain the API yet.
Looking at

elasticsearch/qa/rolling-upgrade/src/javaRestTest/java/org/elasticsearch/upgrades/HealthNodeUpgradeIT.java

Line 32 in b676d38

if (clusterHasFeature("health.supports_health")) {

it looks like clusterHasFeature might behave differently than expected as it always returns true instead of checking the actual feature in the cluster version?

elasticsearch/test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java

Lines 235 to 237 in b676d38

	public boolean clusterHasFeature(String featureId) {
	return true;
	}

I've tried looking at other rolling-upgrade tests, but I'm not quite sure what the fix for this would be in this test setup.

[gmarouli]

Oh boy.... I spent time trying to find out why the cluster feature was not behaving as expected that I completely forgot that the health API was first released as technical preview under a different path https://www.elastic.co/guide/en/elasticsearch/reference/8.6/health-api.html. I am fixing it.