lucene_snapshot: ScriptedSimilarityTests.testInitScript fails with assertion

[ChrisHegarty]

Fails in the lucene_snapshot branch, with:

REPRODUCE WITH: ./gradlew ":server:test" --tests "org.elasticsearch.index.similarity.ScriptedSimilarityTests.testInitScript" -Dtests.seed=6A66977C18D41170 -Dtests.locale=luy-KE -Dtests.timezone=Africa/Dar_es_Salaam -Druntime.java=24
ScriptedSimilarityTests > testInitScript FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([6A66977C18D41170:C04AF38B02997F45]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.elasticsearch.index.similarity.ScriptedSimilarityTests.testInitScript(ScriptedSimilarityTests.java:241)

[elasticsearchmachine]

Pinging @elastic/es-search (Team:Search)

[ChrisHegarty]

Muted by 015581e

[ChrisHegarty]

Likely fix, to allow for BulkScoreBulkScorer calling TermScorer::nextDocsAndScores :

$ git diff
diff --git a/server/src/test/java/org/elasticsearch/index/similarity/ScriptedSimilarityTests.java b/server/src/test/java/org/elasticsearch/index/similarity/ScriptedSimilarityTests.java
index 413fa656494e..3bc9377d74ff 100644
--- a/server/src/test/java/org/elasticsearch/index/similarity/ScriptedSimilarityTests.java
+++ b/server/src/test/java/org/elasticsearch/index/similarity/ScriptedSimilarityTests.java
@@ -189,7 +189,8 @@ public class ScriptedSimilarityTests extends ESTestCase {
 
                     StackTraceElement[] stackTraceElements = Thread.currentThread().getStackTrace();
                     if (Arrays.stream(stackTraceElements).anyMatch(ste -> {
-                        return ste.getClassName().endsWith(".TermScorer") && ste.getMethodName().equals("score");
+                        return ste.getClassName().endsWith(".TermScorer")
+                            && (ste.getMethodName().equals("score") || ste.getMethodName().equals("nextDocsAndScores"));
                     }) == false) {
                         // this might happen when computing max scores
                         return Float.MAX_VALUE;
$