Additional trace logging for ESSingleNodeTestCase failures #110790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>test
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
Author
|
@elasticmachine update branch |
carlosdelest
approved these changes
Jul 11, 2024
Member
carlosdelest
left a comment
carlosdelest
left a comment
There was a problem hiding this comment.
I hope you catch that 🐛 !
benwtrent
reviewed
Jul 11, 2024
| } | ||
|
|
||
| protected void putReaderContext(ReaderContext context) { | ||
| logger.trace("adding reader context [{}]", context.id()); |
Member
There was a problem hiding this comment.
I don't think we want to accidentally merge this into main. The test seems to fail enough that it should be reproducible locally or with this PR if the test is unmuted.
Contributor
Author
There was a problem hiding this comment.
Hmm fair enough. Would you be worried of potential impact with this addition?
Tbh, I haven't been lucky locally even after a huge number of runs. Will try to reproduce within this PR :)
javanna
added
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
This was referenced Jul 18, 2024
Contributor
Author
|
buildkite test this please |
Contributor
Author
|
buildkite test this please |
Contributor
Author
|
Closing as a fix for this has been merged through #111153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #110786