Remove match command #113383
Merged
Remove match command #113383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
Team:Analytics
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| // TODO Keep adding tests for all unsupported commands | ||
| } | ||
|
|
||
| private void assertMatchCommand(String lineAndColumn, String command, String query) { |
Member
There was a problem hiding this comment.
If there is no test besides testMatchCommand calls assertMatchCommand, it can also be removed.
fang-xing-esql
approved these changes
Sep 24, 2024
Member
fang-xing-esql
left a comment
fang-xing-esql
left a comment
There was a problem hiding this comment.
LGTM, just wait for CI to be cleared, thank you!
Contributor
|
@elasticmachine run elasticsearch-ci/release-tests |
Contributor
Author
|
For the release-tests, the failures are related to #113496 which don't have to do with the changes we have here. |
Collaborator
💚 Backport successful
|
ioanatia
added a commit
to ioanatia/elasticsearch
that referenced
this pull request
Sep 25, 2024
* Remove match command * Remove assertMatchCommand * Remove unused import
ioanatia
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to replace the
matchcommand with theqstrfunction (added in #112590)