No longer require logs@settings component template to enable logsdb by default. #114501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
:StorageEngine/Logs
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
changed the title
salvatore-campagna
approved these changes
Oct 10, 2024
| template: | ||
| settings: | ||
| codec: best_compression | ||
| mode: standard |
There was a problem hiding this comment.
This is required to opt-out right?
There was a problem hiding this comment.
Confirming my understanding here, this means that logsdb will be disabled for APM and we will have same behaviour as before - is this right?
otherwise we enable logsdb all nodes are upgraded.
martijnvg
commented
Oct 10, 2024
...-upgrade/src/javaRestTest/java/org/elasticsearch/upgrades/LogsIndexModeRollingUpgradeIT.java
Outdated
Show resolved
Hide resolved
…ult disabled and after upgrade turn it on.
martijnvg
commented
Oct 10, 2024
| } | ||
| }"""; | ||
|
|
||
| private static final String LOGS_TEMPLATE = """ |
There was a problem hiding this comment.
@salvatore-campagna fyi, this test both used cluster.logsdb.enabled=true and template with index.mode set to logsdb. With this change because cluster.logsdb.enabled was set to true, the data stream was in logsdb mode from the start. So I slightly changed this test, so that we still test rolling upgrade from standard mode and after upgrade update to logsdb.
There was a problem hiding this comment.
Now that the setting is dynamic we can do that...before it was static...
martijnvg
added
the
auto-backport
💚 Backport successful
|
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 10, 2024
…y default. (elastic#114501) This change also opts out apm logs from logsdb.
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
…y default. (elastic#114501) This change also opts out apm logs from logsdb.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
…y default. (elastic#114501) This change also opts out apm logs from logsdb.
inge4pres
added a commit
that referenced
this pull request
Oct 28, 2024
Restore standard mode after LogsDB took precedence. Related: #114501
inge4pres
added a commit
that referenced
this pull request
Oct 28, 2024
Restore standard mode after LogsDB took precedence. Related: #114501
inge4pres
added a commit
to inge4pres/elasticsearch
that referenced
this pull request
Oct 30, 2024
Restore standard mode after LogsDB took precedence. Related: elastic#114501 (cherry picked from commit 2b1dc5a)
inge4pres
added a commit
that referenced
this pull request
Oct 30, 2024
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Nov 4, 2024
Restore standard mode after LogsDB took precedence. Related: elastic#114501
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Restore standard mode after LogsDB took precedence. Related: elastic#114501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also opts out apm logs from logsdb.