Skip to content

Unmute MultiVersionRepositoryAccessIT.testReadOnlyRepo #115215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2024
Merged

Unmute MultiVersionRepositoryAccessIT.testReadOnlyRepo #115215

merged 3 commits into from
Oct 22, 2024

Conversation

@pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Oct 21, 2024

I think the test failure opened is not correct, and relates to another failure.

Relates #114999 and #114997.

@pxsalehi pxsalehi added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Oct 21, 2024
@pxsalehi pxsalehi requested a review from ywangd October 21, 2024 12:03
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0 labels Oct 21, 2024
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 21, 2024

Pinging @elastic/es-distributed (Team:Distributed)

@pxsalehi
Copy link
Member Author

pxsalehi commented Oct 21, 2024

(Unless I've missed something about how these tests are set up / run)

@pxsalehi
Copy link
Member Author

pxsalehi commented Oct 21, 2024

@elasticmachine update branch

@pxsalehi pxsalehi requested a review from idegtiarenko October 21, 2024 13:25
ywangd
ywangd approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we can unmute for #114998 as well?

@pxsalehi pxsalehi added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 22, 2024
@elasticsearchmachine elasticsearchmachine merged commit 05fc23a into elastic:main Oct 22, 2024
16 checks passed
@pxsalehi pxsalehi deleted the ps241021-unmute-MultiVersionRepositoryAccessIT.testReadOnlyRepo branch October 22, 2024 08:51
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
@pxsalehi @georgewallace
Unmute MultiVersionRepositoryAccessIT.testReadOnlyRepo (elastic#115215)
c5ae785 
I think the test failure opened is not correct, and relates to another
failure.

Relates elastic#114999 and
elastic#114997.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
@pxsalehi @jfreden
Unmute MultiVersionRepositoryAccessIT.testReadOnlyRepo (elastic#115215)
3224dd3 
I think the test failure opened is not correct, and relates to another
failure.

Relates elastic#114999 and
elastic#114997.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd approved these changes

@idegtiarenko idegtiarenko Awaiting requested review from idegtiarenko

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pxsalehi @elasticsearchmachine @ywangd @elasticmachine