Refactor PipelineConfiguration#getVersion #115423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Oct 23, 2024
Collaborator
💚 Backport successful
|
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Oct 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 23, 2024
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Oct 23, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no benefit in calling
containsKeyand thenget-- we can just callgetand eat thenullvalue. Since this code handles the absence of a key and the presence of anullvalue in the exact same way, it's less code to just collapse the two paths together. It's also imperceptibly faster, but that doesn't really matter.