Skip to content

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 23, 2024

Fix the test muting on the test for grapheme clusters - it should only allow the test if we're on the 20+ jvm.

Closes #114536

Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes elastic#114536
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests backport :Analytics/ES|QL AKA ESQL v9.0.0 v8.16.1 v8.17.0 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 23, 2024
@nik9000
Copy link
Member Author

nik9000 commented Oct 23, 2024

I've targeted 8.16 for this one because I could test more failure cases. I'll forward port to 8.x and main after this merged.

@elasticsearchmachine elasticsearchmachine merged commit ffe836e into elastic:8.16 Oct 23, 2024
15 checks passed
@nik9000 nik9000 deleted the esql_gapheme_cluster_reverse2 branch October 23, 2024 19:11
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Oct 23, 2024
Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes elastic#114536
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Oct 23, 2024
Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes elastic#114536
elasticsearchmachine pushed a commit that referenced this pull request Oct 23, 2024
Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes #114536
elasticsearchmachine pushed a commit that referenced this pull request Oct 23, 2024
* ESQL: Fix test muting (#115448)

Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes #114536

* Change old explanation
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 24, 2024
Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes elastic#114536
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Oct 25, 2024
Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes elastic#114536
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
Fix the test muting on the test for grapheme clusters - it should only
allow the test if we're on the 20+ jvm.

Closes elastic#114536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >test Issues or PRs that are addressing/adding tests v8.16.1 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants