Skip to content

ESQL: Fix test muting #115448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

ESQL: Fix test muting #115448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,6 @@ tests:
- class: org.elasticsearch.xpack.enrich.EnrichIT
method: testEnrichSpecialTypes
issue: https://github.com/elastic/elasticsearch/issues/114773
- class: org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT
method: test {string.ReverseGraphemeClusters}
issue: https://github.com/elastic/elasticsearch/issues/114560
- class: org.elasticsearch.license.LicensingTests
issue: https://github.com/elastic/elasticsearch/issues/114865
- class: org.elasticsearch.xpack.enrich.EnrichIT
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public enum Cap {
* Support for reversing whole grapheme clusters. This is not supported
* on JDK versions less than 20.
*/
FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() < 20),
FN_REVERSE_GRAPHEME_CLUSTERS(Runtime.version().feature() >= 20),

/**
* Support for function {@code CBRT}. Done in #108574.
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/CsvTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ public final void test() throws Throwable {
testCase.requiredCapabilities,
everyItem(in(EsqlCapabilities.capabilities(true)))
);
assumeTrue(
"Capability is not included in the enabled list capabilities on a snapshot build. Spelling mistake?",
EsqlCapabilities.capabilities(false).containsAll(testCase.requiredCapabilities)
);
} else {
for (EsqlCapabilities.Cap c : EsqlCapabilities.Cap.values()) {
if (false == c.isEnabled()) {
Expand Down