Skip to content

[8.x] [Test] Use stream.next instead of setAutoRead in test (#115063) #115893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[8.x] [Test] Use stream.next instead of setAutoRead in test (#115063) #115893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...nalClusterTest/java/org/elasticsearch/http/netty4/Netty4IncrementalRequestHandlingIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,12 +176,16 @@ public void testClientConnectionCloseMidStream() throws Exception {
var handler = ctx.awaitRestChannelAccepted(opaqueId);
assertBusy(() -> assertNotNull(handler.stream.buf()));

// enable auto-read to receive channel close event
handler.stream.channel().config().setAutoRead(true);
assertFalse(handler.streamClosed);

// terminate connection and wait resources are released
// terminate client connection
ctx.clientChannel.close();
// read the first half of the request
handler.stream.next();
// attempt to read more data and it should notice channel being closed eventually
handler.stream.next();

// wait for resources to be released
assertBusy(() -> {
assertNull(handler.stream.buf());
assertTrue(handler.streamClosed);
Expand Down