Skip to content

[8.x] Fix TranslogDeletionPolicy when assertions are disabled (#116654) #116714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

[8.x] Fix TranslogDeletionPolicy when assertions are disabled (#116654) #116714

merged 2 commits into from
Nov 13, 2024

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Nov 13, 2024

Backports the following commits to 8.x:

@tlrx
Fix TranslogDeletionPolicy when assertions are disabled (elastic#116654)
ebe1ac4 
Current code causes a NPE when assertions are disabled: the 
openTranslogRef is only non-null when assertions are enabled.
@tlrx tlrx added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Indexing Meta label for Distributed Indexing team labels Nov 13, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Nov 13, 2024
Merged
@tlrx
Copy link
Member Author

tlrx commented Nov 13, 2024

@elasticmachine update branch

@tlrx
Copy link
Member Author

tlrx commented Nov 13, 2024

@elasticmachine run elasticsearch-ci/bwc-snapshots

@elasticsearchmachine elasticsearchmachine merged commit d6b2425 into elastic:8.x Nov 13, 2024
15 checks passed
@tlrx tlrx deleted the backport/8.x/pr-116654 branch November 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v8.17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tlrx @elasticsearchmachine @elasticmachine