Skip to content

[8.16] Construct list manually in AggregatorsReducer#get (#119565) #119568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025
Merged

[8.16] Construct list manually in AggregatorsReducer#get (#119565) #119568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server/src/main/java/org/elasticsearch/search/aggregations/AggregatorsReducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
import org.elasticsearch.core.Releasable;
import org.elasticsearch.core.Releasables;

import java.util.ArrayList;
import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
Expand Down Expand Up @@ -54,7 +57,12 @@ public void accept(InternalAggregations aggregations) {
* returns the reduced {@link InternalAggregations}.
*/
public InternalAggregations get() {
return InternalAggregations.from(aggByName.values().stream().map(AggregatorReducer::get).toList());
final Collection<AggregatorReducer> reducers = aggByName.values();
final List<InternalAggregation> aggs = new ArrayList<>(reducers.size());
for (AggregatorReducer reducer : reducers) {
aggs.add(reducer.get());
}
return InternalAggregations.from(aggs);
}

@Override
Expand Down