Clean up lingering tasks after DatafeedJobsIT. #120040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-elastic
added
>test-failure
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
elasticsearchmachine
added
the
needs:risk
jan-elastic
removed
the
needs:risk
elasticsearchmachine
added
the
needs:risk
jonathan-buttner
approved these changes
Jan 13, 2025
Contributor
jonathan-buttner
left a comment
jonathan-buttner
left a comment
There was a problem hiding this comment.
Are tests being run on the main branch? If so, I wonder why they aren't failing there too 🤔
Contributor
Author
|
Seems to be a very rare race condition |
jan-elastic
added a commit
that referenced
this pull request
Jan 13, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Clean up lingering tasks after DatafeedJobsIT. (#120040) * unmute tests
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jan 14, 2025
jan-elastic
added a commit
that referenced
this pull request
Jan 16, 2025
jan-elastic
added a commit
that referenced
this pull request
Jan 16, 2025
jan-elastic
added a commit
that referenced
this pull request
Jan 16, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Clean up lingering tasks after DatafeedJobsIT. (#120040) * [8.x] backport datafeeds test fixes (#120289) * Fix(?) and unmute DatafeedJobsRestIT. (#119839) * Fix(?) and unmute DatafeedJobsRestIT. * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> * Datafeed jobs it wait for task cancel (#120177) * Fix task cancellation in DatafeedJobsIT. * fix * unmute DatafeedJobsIT * unmute --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These failures are caused by lingering close tasks, that can be traced back to this IT:
When this is merged and backported, I'll unmute these tests on the 8.x branches.