Fix SearchStatesIT.testCanMatch #120046
Merged
Fix SearchStatesIT.testCanMatch #120046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to override the proxy handler here so that the old type free request gets translated to a scroll free request the same way this works out in local cluster execution. closes #118718 Signed-off-by: Armin Braun <me@obrown.io>
original-brownbear
added
the
:Search Foundations/Search
|
|
||
| // BwC handler that translates FREE_CONTEXT_ACTION_NAME into FREE_CONTEXT_SCROLL_ACTION_NAME same way we use | ||
| // FREE_CONTEXT_SCROLL_ACTION_NAME throughout on local nodes | ||
| transportService.registerRequestHandler( |
Contributor
Author
There was a problem hiding this comment.
I'm not too proud of exposing this infrastructure just for a one-off fix to be honest. But then again, hiding it behind some utility method and adding a single-use abstraction for the action-to-action translation seemed even worse. This solution is the minimum amount of code needed as far as I can tell which is quite helpful.
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
andreidan
approved these changes
Jan 17, 2025
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for iterating on this Armin
Just a note - we'll forward port this to main as well.
Contributor
Author
|
Thanks Andrei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding back the old style free request to fix CCS BwC situations where we need to proxy requests exactly as is and can't drop the technically redundant original indices.
closes #118718