[Entitlements] Introducing runtime version-specific checks in IT tests #120265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
approved these changes
Jan 16, 2025
| } | ||
|
|
||
| tasks.withType(CheckForbiddenApisTask).configureEach { | ||
| replaceSignatureFiles 'jdk-signatures' |
Contributor
There was a problem hiding this comment.
This wasn't in the 8.x version. Do you know why it was needed in main?
Contributor
Author
There was a problem hiding this comment.
I think it's due to different versions of the CheckForbiddenApisTask, it fails consistently in main because it's looking for signatures that are not there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port (to main) of the changes introduced in #120027
Cherry-pick of 883f7b2
While not strictly needed ATM for main/9.x, keeping it in sync with 8.x makes auto-backport work.