Skip to content

[DOCS] Fixes max_chunk_size parameter name in Inference API docs #121052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

[DOCS] Fixes max_chunk_size parameter name in Inference API docs #121052

merged 1 commit into from
Jan 28, 2025

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jan 28, 2025

Overview

This PR changes the occurrences of max_chunking_size to the correct form of max_chunk_size in the inference API reference docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Jan 28, 2025
@szabosteve szabosteve added >docs General docs changes :ml Machine learning Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v8.18.0 v8.17.2 v8.16.4 and removed needs:triage Requires assignment of a team area label labels Jan 28, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Jan 28, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 28, 2025

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 28, 2025

Pinging @elastic/es-docs (Team:Docs)

dan-rubinstein
dan-rubinstein approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@dan-rubinstein dan-rubinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve merged commit 08255da into elastic:main Jan 28, 2025
7 checks passed
@szabosteve szabosteve deleted the fix-max-chunk-size branch January 28, 2025 16:10
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Jan 28, 2025
@szabosteve
[DOCS] Fixes max_chunk_size parameter name. (elastic#121052)
d08995b
@szabosteve szabosteve mentioned this pull request Jan 28, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 28, 2025

💔 Backport failed

Status Branch Result
✅ 8.x
❌ 8.17 Commit could not be cherrypicked due to conflicts
❌ 8.16 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121052

elasticsearchmachine pushed a commit that referenced this pull request Jan 28, 2025
@szabosteve
[DOCS] Fixes max_chunk_size parameter name. (#121052) (#121060)
f057c42
This was referenced Jan 28, 2025
Merged
Merged
@szabosteve
Copy link
Contributor Author

szabosteve commented Jan 28, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.16

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dan-rubinstein dan-rubinstein dan-rubinstein approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.16.4 v8.17.2 v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szabosteve @elasticsearchmachine @dan-rubinstein