Skip to content

Conversation

@joegallo
Copy link
Contributor

Follow up to #120966

This updates the geoip FullClusterRestartIT to run under security (or not, if you indicate that at the command line). It also makes the test pass in both scenarios, but captures that there's a deviation in behavior for the security-on case.

@joegallo joegallo added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v9.0.0 v8.18.0 labels Jan 28, 2025
@joegallo joegallo requested a review from masseyke January 28, 2025 18:31
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@joegallo joegallo added auto-backport Automatically create backport pull requests when merged and removed auto-backport Automatically create backport pull requests when merged labels Jan 28, 2025
@joegallo
Copy link
Contributor Author

I'm not relying on auto-backport for this PR because there would be a conflict anyway.

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joegallo joegallo merged commit 4127f5c into elastic:main Jan 28, 2025
16 checks passed
@joegallo joegallo deleted the extend-geoip-migration-test branch January 28, 2025 22:08
@joegallo
Copy link
Contributor Author

I ran into a problem while trying to backport this PR, so for now I'm leaving this as 'backport pending'.

@joegallo
Copy link
Contributor Author

The backport is up via #121123, and it'll be merged momentarily, so I'm dropping 'backport pending' from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants