Skip to content

Fix testResetAllocationFailuresOnNodeShutdown #121378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix testResetAllocationFailuresOnNodeShutdown #121378

merged 3 commits into from
Feb 4, 2025

Conversation

@pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Jan 31, 2025 •
edited
Loading

The new IT assumes that ensureRed means we've exhausted all the attempts for allocation, which doesn't hold always.

Closes #121129

@pxsalehi pxsalehi added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Jan 31, 2025
@elasticsearchmachine elasticsearchmachine added Team:Distributed Coordination Meta label for Distributed Coordination team v9.1.0 labels Jan 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@pxsalehi pxsalehi requested review from mhl-b and ywangd January 31, 2025 10:24
mhl-b
mhl-b approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@mhl-b mhl-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ywangd
ywangd approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@pxsalehi pxsalehi enabled auto-merge (squash) February 3, 2025 09:29
@pxsalehi pxsalehi merged commit 0cd3ff5 into elastic:main Feb 4, 2025
17 checks passed
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Feb 4, 2025
@pxsalehi @fzowl
Fix AllocationFailuresResetOnShutdownIT#testResetAllocationFailuresOn…
f28cf53 
…NodeShutdown (elastic#121378)

The ITs assumes that `ensureRed` means we've exhausted all the attempts for allocation, which doesn't hold always. 

Closes elastic#121129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd approved these changes

@mhl-b mhl-b mhl-b approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] AllocationFailuresResetOnShutdownIT testResetAllocationFailuresOnNodeShutdown failing

4 participants

@pxsalehi @elasticsearchmachine @ywangd @mhl-b