Skip to content

[Entitlements] Add some missing instrumentation (nio providers) #122004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

[Entitlements] Add some missing instrumentation (nio providers) #122004

merged 1 commit into from
Feb 7, 2025

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented Feb 7, 2025

This PR adds instrumentation from some general and network specific NIO providers, which we missed during the first pass.

Relates to ES-10355

@ldematte ldematte added >non-issue :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged test-entitlements v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Feb 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 7, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 7, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ldematte ldematte requested a review from a team February 7, 2025 10:08
jdconrad
jdconrad approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldematte ldematte merged commit 0534074 into elastic:main Feb 7, 2025
22 checks passed
@ldematte ldematte deleted the entitlements/missing-network-providers branch February 7, 2025 16:09
@ldematte ldematte mentioned this pull request Feb 7, 2025
Merged
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Feb 7, 2025
@ldematte
Missing providers from nio (elastic#122004)
49e2b7b
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Feb 7, 2025
@ldematte
Missing providers from nio (elastic#122004)
e861b67
@ldematte ldematte mentioned this pull request Feb 7, 2025
Merged
ldematte added a commit to ldematte/elasticsearch that referenced this pull request Feb 7, 2025
@ldematte
Missing providers from nio (elastic#122004)
eaea08d
@ldematte ldematte mentioned this pull request Feb 7, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 7, 2025

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.x
✅ 9.0

elasticsearchmachine pushed a commit that referenced this pull request Feb 7, 2025
@ldematte
Missing providers from nio (#122004) (#122053)
b29a5ae
elasticsearchmachine pushed a commit that referenced this pull request Feb 7, 2025
@ldematte
Missing providers from nio (#122004) (#122052)
7a089d9
elasticsearchmachine pushed a commit that referenced this pull request Feb 7, 2025
@ldematte
Missing providers from nio (#122004) (#122051)
ba9b6d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdconrad jdconrad jdconrad approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ldematte @elasticsearchmachine @jdconrad