- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Handle exceptions when register compute group #123438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Pinging @elastic/es-analytical-engine (Team:Analytics)  | 
    
| } | ||
| 
               | 
          ||
| CancellableTask createGroupTask(Task parentTask, Supplier<String> description) { | ||
| CancellableTask createGroupTask(Task parentTask, Supplier<String> description) throws TaskCancelledException { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't TaskCancelledException a runtime exception? So making it checked here doesn't do much except documenting the fact it may be thrown, am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct.
| 
           Thanks everyone!  | 
    
          💚 Backport successful
  | 
    
If the parent task is canceled, registering the compute group task might throw a TaskCancelledException, so the listener won't be notified.
Closes #123216
Closes #123101
Closes #123451