Skip to content

Re-enable testCancelFailedSearchWhenPartialResultDisallowed, the issue should already be fixed #124510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Re-enable testCancelFailedSearchWhenPartialResultDisallowed, the issue should already be fixed #124510

merged 1 commit into from
Mar 11, 2025

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Mar 10, 2025

See #99929

@smalyshev smalyshev changed the base branch from main to 9.0 March 10, 2025 19:04
@smalyshev smalyshev changed the title Enable test cancel failed search when partial result disallowed Re-enable testCancelFailedSearchWhenPartialResultDisallowed, the issue should already be fixed Mar 10, 2025
@smalyshev smalyshev added >test Issues or PRs that are addressing/adding tests v9.0.1 auto-backport Automatically create backport pull requests when merged v8.18.1 labels Mar 10, 2025
@smalyshev smalyshev marked this pull request as ready for review March 10, 2025 19:05
@smalyshev smalyshev added the :Search Foundations/Search Catch all for Search Foundations label Mar 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Mar 10, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 10, 2025

Pinging @elastic/es-search-foundations (Team:Search Foundations)

drempapis
drempapis approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalyshev smalyshev merged commit 4af2e24 into elastic:9.0 Mar 11, 2025
16 checks passed
@smalyshev smalyshev mentioned this pull request Mar 11, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Mar 11, 2025

💚 Backport successful

Status Branch Result
✅ 8.18

smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Mar 11, 2025
@smalyshev
Re-enable testCancelFailedSearchWhenPartialResultDisallowed, the issu…
c762f41 
…e should already be fixed (elastic#124510)
elasticsearchmachine pushed a commit that referenced this pull request Mar 11, 2025
@smalyshev
Re-enable testCancelFailedSearchWhenPartialResultDisallowed, the issu…
80c5c40 
…e should already be fixed (#124510) (#124569)
@smalyshev smalyshev deleted the enable-testCancelFailedSearchWhenPartialResultDisallowed branch March 13, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drempapis drempapis drempapis approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.18.1 v9.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smalyshev @elasticsearchmachine @drempapis