- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
Adjusting 41_knn_search_bbq_hnsw tests to have explicit refresh #125255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            benwtrent
  merged 1 commit into
  elastic:main
from
benwtrent:test/adding-refresh-41_knn_search_bbq_hnsw
  
      
      
   
  Mar 20, 2025 
      
    
                
     Merged
            
            Adjusting 41_knn_search_bbq_hnsw tests to have explicit refresh #125255
                    benwtrent
  merged 1 commit into
  elastic:main
from
benwtrent:test/adding-refresh-41_knn_search_bbq_hnsw
  
      
      
   
  Mar 20, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Pinging @elastic/es-search-relevance (Team:Search Relevance)  | 
    
              
                    svilen-mihaylov-elastic
  
              
              approved these changes
              
                  
                    Mar 20, 2025 
                  
              
              
            
            
    
  afoucret 
      pushed a commit
        to afoucret/elasticsearch
      that referenced
      this pull request
    
      Mar 21, 2025 
    
    
  
    
  smalyshev 
      pushed a commit
        to smalyshev/elasticsearch
      that referenced
      this pull request
    
      Mar 21, 2025 
    
    
  
    
  benwtrent 
      added a commit
        to benwtrent/elasticsearch
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
      
  
    
      
    
  
…tic#125255) (cherry picked from commit e9c4b26)
  This was referenced Mar 28, 2025 
      
    
  benwtrent 
      added a commit
        to benwtrent/elasticsearch
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
      
  
    
      
    
  
…tic#125255) (cherry picked from commit e9c4b26)
          💚 All backports created successfully
 Questions ?Please refer to the Backport tool documentation  | 
    
    
  benwtrent 
      added a commit
        to benwtrent/elasticsearch
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
      
  
    
      
    
  
…tic#125255) (cherry picked from commit e9c4b26)
    
  omricohenn 
      pushed a commit
        to omricohenn/elasticsearch
      that referenced
      this pull request
    
      Mar 28, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    :Search Relevance/Vectors
  Vector search 
  
    Team:Search Relevance
  Meta label for the Search Relevance team in Elasticsearch 
  
    >test
  Issues or PRs that are addressing/adding tests 
  
    v9.1.0
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This should handle any weird flakiness with CoreWithMultipleProjectsClientYamlTestSuiteIT, if not, involve
CoreWithMultipleProjectsClientYamlTestSuiteITauthors as its the only runner failing "Vector rescoring has same scoring as exact search for kNN section" right now