Skip to content

[8.x] Leverage scorer supplier in QueryFeatureExtractor (#125259) #125295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
+11 −3
Merged

[8.x] Leverage scorer supplier in QueryFeatureExtractor (#125259) #125295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/125259.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 125259
summary: Leverage scorer supplier in `QueryFeatureExtractor`
area: Ranking
type: enhancement
issues: []
9 changes: 6 additions & 3 deletions ...ugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/ltr/QueryFeatureExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,12 @@ public void setNextReader(LeafReaderContext segmentContext) throws IOException {
if (weight == null) {
continue;
}
Scorer scorer = weight.scorer(segmentContext);
if (scorer != null) {
subScorers.add(new FeatureDisiWrapper(scorer, featureNames.get(i)));
var scorerSupplier = weight.scorerSupplier(segmentContext);
if (scorerSupplier != null) {
var scorer = scorerSupplier.get(0L);
if (scorer != null) {
subScorers.add(new FeatureDisiWrapper(scorer, featureNames.get(i)));
}
}
}
approximation = subScorers.size() > 0 ? new DisjunctionDISIApproximation(subScorers) : null;
Expand Down