Remove redundant consumeAll call on in QueryPhaseResultConsumer#125299
Closed
original-brownbear wants to merge 1 commit intoelastic:mainfrom
Closed
Remove redundant consumeAll call on in QueryPhaseResultConsumer#125299original-brownbear wants to merge 1 commit intoelastic:mainfrom
consumeAll call on in QueryPhaseResultConsumer#125299original-brownbear wants to merge 1 commit intoelastic:mainfrom
Conversation
It's in the title, no need to call this for a null response.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
approved these changes
Mar 31, 2025
Contributor
drempapis
left a comment
drempapis
left a comment
There was a problem hiding this comment.
Reading the result.consumeAll code this update LGTM.
Contributor
Author
|
Thanks Dimistris! This one I already integrated into #121885 by accident, sorry :) Nothing to merge left :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is redundant, no need to call this for a null response which has none of the fields that
consumeAllnulls out set in the first place.