Inline redundant SingleBucketAggregation interface #127093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface is just implemented once, inline it into the abstract parent of all other implementations.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
| /** | ||
| * Results of the {@link ParentToChildrenAggregator}. | ||
| */ | ||
| public class InternalChildren extends InternalSingleBucketAggregation { |
Contributor
Author
There was a problem hiding this comment.
The motivation in cleaning this up shoud become visible here, all but one implementation of SingleBucketAggregation are noop overrides. We can (with a bit of BwC code for the transport layer) fold all of these into a single class and save both a lot of code but also make serialization a lot more compact (and faster!).
| * A base class for all the single bucket aggregations. | ||
| */ | ||
| public interface SingleBucketAggregation extends Aggregation { | ||
| public class SingleBucketAggregation extends InternalAggregation { |
Contributor
Author
There was a problem hiding this comment.
Making this a concrete class. For now, that only cleans up some testing and allows us to replace the mocks with actual instances. But going forward, we should be able to remove the various noop subclasses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface is just implemented once, inline it into the abstract parent of all other implementations.
Sorry that the diff is a little hard to follow for the
SingleBucketAggregationfile because of the rename. I still figured it was cleaner to do the rename and inline in one go but happy to change that if it's hard to follow.Hopefully it's ok because this is just a mechanical PR, but happy to do without the rename of the abstract class to the interface for a shorter PR.