Skip to content

Updating score assertions to use close_to instead of match for linear_retriever yml tests #128865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Updating score assertions to use close_to instead of match for linear_retriever yml tests #128865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56ea498
updating score assertions to use close_to instead of match
pmpailis Jun 3, 2025
0153756
Merge branch 'main' into fix_128774_for_floating_point_comparisons
pmpailis Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,9 +495,6 @@ tests:
- class: org.elasticsearch.packaging.test.DockerTests
method: test040JavaUsesTheOsProvidedKeystore
issue: https://github.com/elastic/elasticsearch/issues/128230
- class: org.elasticsearch.xpack.rank.rrf.LinearRankClientYamlTestSuiteIT
method: test {yaml=linear/10_linear_retriever/should normalize initial scores with l2_norm}
issue: https://github.com/elastic/elasticsearch/issues/128774
- class: org.elasticsearch.index.codec.vectors.es818.ES818HnswBinaryQuantizedVectorsFormatTests
method: testSimpleOffHeapSizeFSDir
issue: https://github.com/elastic/elasticsearch/issues/128799
Expand Down
45 changes: 22 additions & 23 deletions ...gin/rank-rrf/src/yamlRestTest/resources/rest-api-spec/test/linear/10_linear_retriever.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ setup:

- match: { hits.total.value: 2 }
- match: { hits.hits.0._id: "1" }
- match: { hits.hits.0._score: 5.0 }
- close_to: { hits.hits.0._score: { value: 5.0, error: 0.001} }
- match: { hits.hits.1._id: "4" }
- match: { hits.hits.1._score: 2.0 }
- close_to: { hits.hits.1._score: { value: 2.0, error: 0.001} }

---
"basic linear weighted combination - interleaved results":
Expand Down Expand Up @@ -174,13 +174,13 @@ setup:

- match: { hits.total.value: 4 }
- match: { hits.hits.0._id: "1" }
- match: { hits.hits.0._score: 20.0 }
- close_to: { hits.hits.0._score: { value: 20.0, error: 0.001} }
- match: { hits.hits.1._id: "3" }
- match: { hits.hits.1._score: 15.0 }
- close_to: { hits.hits.1._score: { value: 15.0, error: 0.001} }
- match: { hits.hits.2._id: "4" }
- match: { hits.hits.2._score: 12.0 }
- close_to: { hits.hits.2._score: { value: 12.0, error: 0.001} }
- match: { hits.hits.3._id: "2" }
- match: { hits.hits.3._score: 10.0 }
- close_to: { hits.hits.3._score: { value: 10.0, error: 0.001} }

---
"should normalize initial scores":
Expand Down Expand Up @@ -256,12 +256,11 @@ setup:

- match: { hits.total.value: 4 }
- match: { hits.hits.0._id: "1" }
- match: {hits.hits.0._score: 10.0}
- close_to: { hits.hits.0._score: { value: 10.0, error: 0.001} }
- match: { hits.hits.1._id: "2" }
- match: {hits.hits.1._score: 8.0}
- close_to: { hits.hits.1._score: { value: 8.0, error: 0.001} }
- match: { hits.hits.2._id: "4" }
- match: {hits.hits.2._score: 2.0}
- match: { hits.hits.2._score: 2.0 }
- close_to: { hits.hits.2._score: { value: 2.0, error: 0.001} }
- match: { hits.hits.3._id: "3" }
- close_to: { hits.hits.3._score: { value: 0.0, error: 0.001 } }

Expand Down Expand Up @@ -310,13 +309,13 @@ setup:

- match: { hits.total.value: 4 }
- match: { hits.hits.0._id: "2" }
- match: { hits.hits.0._score: 8.0 }
- close_to: { hits.hits.0._score: { value: 8.0, error: 0.001} }
- match: { hits.hits.1._id: "1" }
- match: { hits.hits.1._score: 6.0 }
- close_to: { hits.hits.1._score: { value: 6.0, error: 0.001} }
- match: { hits.hits.2._id: "4" }
- close_to: { hits.hits.2._score: { value: 1.6, error: 0.001 } }
- match: { hits.hits.3._id: "3" }
- match: { hits.hits.3._score: 1.2 }
- close_to: { hits.hits.3._score: { value: 1.2, error: 0.001} }

---
"should handle all zero scores in normalization":
Expand Down Expand Up @@ -514,7 +513,7 @@ setup:
- match: { hits.total.value: 4 }
- length: { hits.hits: 1 }
- match: { hits.hits.0._id: "4" }
- match: { hits.hits.0._score: 2.0 }
- close_to: { hits.hits.0._score: { value: 2.0, error: 0.001} }

- do:
search:
Expand Down Expand Up @@ -703,9 +702,9 @@ setup:

- match: { hits.total.value: 4 }
- match: { hits.hits.0._id: "4" }
- match: { hits.hits.0._score: 2.0 }
- close_to: { hits.hits.0._score: { value: 2.0, error: 0.001} }
- match: { hits.hits.1._id: "1" }
- match: { hits.hits.1._score: 1.0 }
- close_to: { hits.hits.1._score: { value: 1.0, error: 0.001} }

---
"explain should provide info on weights and inner retrievers":
Expand Down Expand Up @@ -908,11 +907,11 @@ setup:

- match: { hits.total.value: 3 }
- match: { hits.hits.0._id: "2" }
- match: { hits.hits.0._score: 40.0 }
- close_to: { hits.hits.0._score: { value: 40.0, error: 0.001} }
- match: { hits.hits.1._id: "1" }
- match: { hits.hits.1._score: 5.0 }
- close_to: { hits.hits.1._score: { value: 5.0, error: 0.001} }
- match: { hits.hits.2._id: "4" }
- match: { hits.hits.2._score: 2.0 }
- close_to: { hits.hits.2._score: { value: 2.0, error: 0.001} }

---
"linear retriever with filters":
Expand Down Expand Up @@ -962,7 +961,7 @@ setup:
- match: { hits.total.value: 1 }
- length: {hits.hits: 1}
- match: { hits.hits.0._id: "4" }
- match: { hits.hits.0._score: 2.0 }
- close_to: { hits.hits.0._score: { value: 2.0, error: 0.001} }

---
"linear retriever with filters on nested retrievers":
Expand Down Expand Up @@ -1013,7 +1012,7 @@ setup:
- match: { hits.total.value: 1 }
- length: {hits.hits: 1}
- match: { hits.hits.0._id: "4" }
- match: { hits.hits.0._score: 2.0 }
- close_to: { hits.hits.0._score: { value: 2.0, error: 0.001} }


---
Expand Down Expand Up @@ -1150,7 +1149,7 @@ setup:
- match: { hits.hits.0._id: "2" }
- close_to: { hits.hits.0._score: { value: 1.5, error: 0.001 } }
- match: { hits.hits.1._id: "1" }
- match: { hits.hits.1._score: 1 }
- close_to: { hits.hits.1._score: { value: 1, error: 0.001} }

---
"should throw when rank_window_size is negative":
Expand Down Expand Up @@ -1222,4 +1221,4 @@ setup:

- match: { hits.total.value: 1 }
- match: { hits.hits.0._id: "1" }
- match: { hits.hits.0._score: 1.0 }
- close_to: { hits.hits.0._score: { value: 1.0, error: 0.001} }