Don't validate index_mode for start_date/end_date index settings #134300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows component templates to set the start/end date without forcing them to set routing_path. This would disable the new index.dimensions-based optimization introduced in elastic#132566.
elasticsearchmachine
added
Team:StorageEngine
v9.2.0
external-contributor
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Sep 8, 2025
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/logsdb/10_settings.yml
Outdated
Show resolved
Hide resolved
felixbarny
commented
Sep 8, 2025
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/logsdb/10_settings.yml
Outdated
Show resolved
Hide resolved
kkrik-es
approved these changes
Sep 8, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 9, 2025
…stic#134300) This allows component templates to set the start/end date without forcing them to set routing_path. This would disable the new index.dimensions-based optimization introduced in elastic#132566.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows component templates to set the start/end date without forcing them to set routing_path. This would disable the new index.dimensions-based optimization introduced in #132566.