Add multi-cluster IT for the TS command #137237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MultiClusterTimeSeriesIT to make sure that the TS command works correctly in the multi-cluster environment. Closes elastic#135218
leontyevdv
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Add MultiClusterTimeSeriesIT to make sure that the TS command works correctly in the multi-cluster environment. Closes elastic#135218
Add MultiClusterTimeSeriesIT to make sure that the TS command works correctly in the multi-cluster environment. Closes elastic#135218
dnhatn
approved these changes
Oct 28, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
One question, but this looks great. Thanks Dima!
| } | ||
|
|
||
| protected boolean supportsAsync() { | ||
| return false; |
Member
There was a problem hiding this comment.
Why do we always need to disable async?
Contributor
Author
There was a problem hiding this comment.
Yeah, I took it from the existing code, particularly from MultiClustersIT.java#L207. Reading the comment, I thought we could use async here and changed it to use the randomBoolean() method. When it's true it fails with the following exception:
MultiClusterTimeSeriesIT > testAvgOverTime FAILED
org.elasticsearch.xcontent.XContentGenerationException: com.fasterxml.jackson.core.JsonGenerationException: Can not write a field name, expecting a value
at __randomizedtesting.SeedInfo.seed([2602953138915D1E:D6848838FA018932]:0)
at org.elasticsearch.xcontent.provider.json.JsonXContentGenerator.writeFieldName(JsonXContentGenerator.java:190)
at app//org.elasticsearch.xcontent.XContentBuilder.field(XContentBuilder.java:373)
at app//org.elasticsearch.xcontent.XContentBuilder.field(XContentBuilder.java:890)
at app//org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase$RequestObjectBuilder.waitForCompletion(RestEsqlTestCase.java:180)
at app//org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase.addAsyncParameters(RestEsqlTestCase.java:1827)
at app//org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase.runEsqlAsync(RestEsqlTestCase.java:1540)
at app//org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase.runEsqlAsync(RestEsqlTestCase.java:1529)
at app//org.elasticsearch.xpack.esql.ccq.MultiClusterTimeSeriesIT.runEsql(MultiClusterTimeSeriesIT.java:295)
at app//org.elasticsearch.xpack.esql.ccq.MultiClusterTimeSeriesIT.run(MultiClusterTimeSeriesIT.java:284)
at app//org.elasticsearch.xpack.esql.ccq.MultiClusterTimeSeriesIT.testAvgOverTime(MultiClusterTimeSeriesIT.java:192)
Caused by:
com.fasterxml.jackson.core.JsonGenerationException: Can not write a field name, expecting a value
at com.fasterxml.jackson.core.JsonGenerator._constructWriteException(JsonGenerator.java:2884)
at com.fasterxml.jackson.core.JsonGenerator._reportError(JsonGenerator.java:2868)
at com.fasterxml.jackson.dataformat.cbor.CBORGenerator.writeFieldName(CBORGenerator.java:528)
at org.elasticsearch.xcontent.provider.json.JsonXContentGenerator.writeFieldName(JsonXContentGenerator.java:188)
... 9 more
Will double-check this.
Test async ESQL calls. Closes elastic#135218
Test async ESQL calls. Closes elastic#135218
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
* [TEST] Add MultiClusterTimeSeriesIT Add MultiClusterTimeSeriesIT to make sure that the TS command works correctly in the multi-cluster environment. Closes elastic#135218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few explicit tests for TS queries covering counter rate and agg_over_time, in a multi-cluster setup.
The strategy of testing is the following: