Log total ingest nodes, don't call reroute when only ML nodes not hot-spotted #137417
+47
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
needs:triage
nicktindall
added
>non-issue
:Distributed Coordination/Allocation
elasticsearchmachine
added
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
nicktindall
commented
Oct 31, 2025
| var totalIngestionNodes = 0; | ||
| for (var entry : clusterInfo.getNodeUsageStatsForThreadPools().entrySet()) { | ||
| final var nodeId = entry.getKey(); | ||
| final var usageStats = entry.getValue(); |
There was a problem hiding this comment.
Just changed to a for-loop so we didn't need to create all these AtomicXXX to store the counter/boolean
DiannaHohensee
approved these changes
Nov 4, 2025
| // TODO (ES-13314): consider stateful data tiers | ||
| return; | ||
| } | ||
| totalIngestionNodes++; |
There was a problem hiding this comment.
nit: seeing ingestion might be giving me indigestion (I couldn't resist...).
I haven't seen ingestion elsewhere. Should this be totalIngestNodes?
...rk/src/main/java/org/elasticsearch/action/support/replication/ClusterStateCreationUtils.java
Show resolved
Hide resolved
.../test/java/org/elasticsearch/cluster/routing/allocation/WriteLoadConstraintMonitorTests.java
Show resolved
Hide resolved
nicktindall
force-pushed
the
log_total_ingest_nodes
branch
from
b5c8ae9 to
34d92df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We log a message to indicate that some nodes are hot-spotted which includes a total node count, e.g.
This PR changes that message to indicate how many "ingest" nodes, or nodes that might be able to have shards moved to them there are.
The PR also excludes ML nodes from that count and from consideration when deciding if there are non-hot-spotted nodes available. Previously only search nodes were excluded.