Skip generation of stacktraces for APM spans. #137435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ES, these stacktraces are generally of fairly little use as these would almost always point to APMTracer.stopTrace being called from TaskManager.unregister. Because of above and as part of the effort to reduce costs of tracing and make it more lightweight, we should just not include stacktraces at all. Relates to ES-12935
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ES, these stacktraces are generally of fairly little use as these would almost always point to APMTracer.stopTrace being called from TaskManager.unregister.
Because of above and as part of the effort to reduce costs of tracing and make it more lightweight, we should just not include stacktraces at all.
Relates to ES-12935