Add missing getters required to reconstruct FunctionScoreQuery #137656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
needs:triage
PeteGillinElastic
added
:Search Relevance/Ranking
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Contributor
|
Thanks @mrkm4ntr ! Change seems rather straightforward and looks ok as far as changing the API goes, since we already have getters for the other members. Let me run CI to get some green checks :) |
Contributor
|
buildkite test this please |
Contributor
|
@mrkm4ntr could you please merge the latest changes from |
Member
|
buildkite test this please |
Contributor
Contributor
|
buildkite test this please |
Contributor
|
CI is green, so will proceed with merging this PR! Thanks @mrkm4ntr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to modify the sub-query of the FunctionScoreQuery after its construction, but since the query field is final, reconstruction is necessary. However, because scoreMode and maxBoost are not accessible, reconstruction is not possible. Therefore, I would like to add getters for these fields.