-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add index.use_time_series_doc_values_format index setting. #137722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index.use_time_series_doc_values_format index setting. #137722
Conversation
This default to true if index mode is time_series and logsdb. But allows anyone to use the time series doc values coded outside of these index modes. Sometimes this makes sense if index sorting is enabled. Additionally, the PerFieldFormatSupplier now just checks the new setting in order to determine whether tsdb doc values codec should be used. This setting should be used over `index.time_series.es87tsdb_codec.enabled`, since that setting acts only as an opt-out if index mode is either logsdb or time_series.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
romseygeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| return useTimeSeriesSyntheticId; | ||
| } | ||
|
|
||
| public boolean isUseTimeSeriesDocValuesCodec() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just call it useTimeSeriesDocValuesCodec? isUse reads a bit strangely to me.
🔍 Preview links for changed docs |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
…37722) This default to true if index mode is time_series and logsdb. But allows anyone to use the time series doc values coded outside of these index modes. Sometimes this makes sense if index sorting is enabled. Additionally, the PerFieldFormatSupplier now just checks the new setting in order to determine whether tsdb doc values codec should be used. This setting should be used over `index.time_series.es87tsdb_codec.enabled`, since that setting acts only as an opt-out if index mode is either logsdb or time_series.
This default to true if index mode is time_series or logsdb. But allows anyone to use the time series doc values coded outside of these index modes. Sometimes this makes sense if index sorting is enabled.
Additionally, the PerFieldFormatSupplier now just checks the new setting in order to determine whether tsdb doc values codec should be used.
This setting should be used over
index.time_series.es87tsdb_codec.enabled, since that setting acts only as an opt-out if index mode is either logsdb or time_series.