Skip to content

Conversation

@martijnvg
Copy link
Member

@martijnvg martijnvg commented Nov 7, 2025

This default to true if index mode is time_series or logsdb. But allows anyone to use the time series doc values coded outside of these index modes. Sometimes this makes sense if index sorting is enabled.

Additionally, the PerFieldFormatSupplier now just checks the new setting in order to determine whether tsdb doc values codec should be used.

This setting should be used over index.time_series.es87tsdb_codec.enabled, since that setting acts only as an opt-out if index mode is either logsdb or time_series.

This default to true if index mode is time_series and logsdb. But allows anyone to use the time series doc values coded outside of these index modes. Sometimes this makes sense if index sorting is enabled.

Additionally, the PerFieldFormatSupplier now just checks the new setting in order to determine whether tsdb doc values codec should be used.

This setting should be used over `index.time_series.es87tsdb_codec.enabled`, since that setting acts only as an opt-out if index mode is either logsdb or time_series.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

return useTimeSeriesSyntheticId;
}

public boolean isUseTimeSeriesDocValuesCodec() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just call it useTimeSeriesDocValuesCodec? isUse reads a bit strangely to me.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

🔍 Preview links for changed docs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@martijnvg martijnvg changed the title Add index.use_time_series_doc_values_codec index setting. Add index.use_time_series_doc_values_format index setting. Nov 7, 2025
@martijnvg martijnvg enabled auto-merge (squash) November 7, 2025 16:08
@martijnvg martijnvg merged commit 526ec65 into elastic:main Nov 7, 2025
34 checks passed
Kubik42 pushed a commit to Kubik42/elasticsearch that referenced this pull request Nov 10, 2025
…37722)

This default to true if index mode is time_series and logsdb. But allows anyone to use the time series doc values coded outside of these index modes. Sometimes this makes sense if index sorting is enabled.

Additionally, the PerFieldFormatSupplier now just checks the new setting in order to determine whether tsdb doc values codec should be used.

This setting should be used over `index.time_series.es87tsdb_codec.enabled`, since that setting acts only as an opt-out if index mode is either logsdb or time_series.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants