Split index-time and search-time sort definitions #137880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At search time, we can now always use our custom comparators that allow pruning on secondary sorts. At index time, we need to always use Lucene SortFields, which is fine as pruning isn't used at this point in any case.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Nov 11, 2025
| private static final Consumer<DocIdSetIterator> checkClass = disi -> { | ||
| assertThat(disi, instanceOf(XUpdateableDocIdSetIterator.class)); | ||
| XUpdateableDocIdSetIterator iterator = (XUpdateableDocIdSetIterator) disi; | ||
| assertThat(iterator.getDelegate().getClass().getName(), containsString("SecondarySortIterator")); |
Contributor
Author
|
Buildkite benchmark this with elastic-logs please |
Collaborator
💚 Build Succeeded
This build ran two elastic-logs benchmarks to evaluate performance impact of this PR. Historycc @romseygeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At search time, we can now always use our custom comparators that
allow pruning on secondary sorts. At index time, we need to always use
Lucene SortFields, which is fine as pruning isn't used at this point in any case.