Skip to content

Only run DirectIOIT with the feature flag #138175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Only run DirectIOIT with the feature flag #138175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c1e6b
Don't run DirectIOIT if feature flag is not enabled
thecoop Nov 17, 2025
4c6f606
Unmute tests
thecoop Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,12 +450,6 @@ tests:
- class: org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorMultipleNodesIT
method: testCancellingAuthorizationTaskRestartsIt
issue: https://github.com/elastic/elasticsearch/issues/138099
- class: org.elasticsearch.index.store.DirectIOIT
method: testDirectIONotUsed {p0=bbq_disk}
issue: https://github.com/elastic/elasticsearch/issues/138102
- class: org.elasticsearch.index.store.DirectIOIT
method: testDirectIOUsed {p0=bbq_disk}
issue: https://github.com/elastic/elasticsearch/issues/138104
- class: org.elasticsearch.xpack.shutdown.NodeShutdownIT
method: testStalledShardMigrationProperlyDetected
issue: https://github.com/elastic/elasticsearch/issues/115697
Expand All @@ -477,12 +471,6 @@ tests:
- class: org.elasticsearch.xpack.downsample.DataStreamLifecycleDownsampleIT
method: testUpdateDownsampleSamplingMode
issue: https://github.com/elastic/elasticsearch/issues/138135
- class: org.elasticsearch.index.store.DirectIOIT
method: testDirectIONotUsed {p0=bbq_hnsw}
issue: https://github.com/elastic/elasticsearch/issues/138101
- class: org.elasticsearch.index.store.DirectIOIT
method: testDirectIOUsed {p0=bbq_hnsw}
issue: https://github.com/elastic/elasticsearch/issues/138103

# Examples:
#
Expand Down
3 changes: 3 additions & 0 deletions server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.apache.lucene.tests.util.LuceneTestCase;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.core.Strings;
import org.elasticsearch.index.codec.vectors.es93.ES93GenericFlatVectorsFormat;
import org.elasticsearch.plugins.Plugin;
import org.elasticsearch.search.vectors.KnnSearchBuilder;
import org.elasticsearch.search.vectors.VectorData;
Expand Down Expand Up @@ -58,6 +59,8 @@ public static void checkSupported() {
} catch (IOException e) {
SUPPORTED = false;
}

assumeTrue("Generic format supporting direct IO not enabled", ES93GenericFlatVectorsFormat.GENERIC_VECTOR_FORMAT.isEnabled());
}

static DirectIODirectory open(Path path) throws IOException {
Expand Down