Skip to content

Fix index.mapping.pattern_text.disable_templating not registered issue #138265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2025
Merged

Fix index.mapping.pattern_text.disable_templating not registered issue #138265

merged 5 commits into from
Nov 19, 2025

Conversation

@parkertimmins
Copy link
Contributor

@parkertimmins parkertimmins commented Nov 18, 2025

While adding PatternTextRollingUpgradeIT came across the following error:

Caused by: java.lang.IllegalArgumentException: setting index.mapping.pattern_text.disable_templating has not been registered
	at org.elasticsearch.server@9.3.0-SNAPSHOT/org.elasticsearch.common.settings.AbstractScopedSettings.get(AbstractScopedSettings.java:775)
	at org.elasticsearch.server@9.3.0-SNAPSHOT/org.elasticsearch.index.IndexSettings.getValue(IndexSettings.java:1759)
	at org.elasticsearch.xpack.logsdb.patterntext.PatternTextFieldMapper$Builder.disableTemplatingParameter(PatternTextFieldMapper.java:171)
	at org.elasticsearch.xpack.logsdb.patterntext.PatternTextFieldMapper$Builder.<init>(PatternTextFieldMapper.java:106)
	at org.elasticsearch.xpack.logsdb.patterntext.PatternTextFieldMapper$Builder.<init>(PatternTextFieldMapper.java:99)
	at org.elasticsearch.server@9.3.0-SNAPSHOT/org.elasticsearch.index.mapper.FieldMapper$TypeParser.parse(FieldMapper.java:1788)
	at org.elasticsearch.server@9.3.0-SNAPSHOT/org.elasticsearch.index.mapper.FieldMapper$TypeParser.parse(FieldMapper.java:1739)
	at org.elasticsearch.server@9.3.0-SNAPSHOT/org.elasticsearch.index.mapper.ObjectMapper$TypeParser.parseProperties(ObjectMapper.java:415)

Loading the setting directly from DISABLE_TEMPLATING_SETTING solves the issue (though I don't fully understand why). It seems that in general index scoped settings in x-pack seem to use this pattern.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 labels Nov 18, 2025
@parkertimmins parkertimmins added >bug auto-backport Automatically create backport pull requests when merged :StorageEngine/Mapping The storage related side of mappings v9.0.2 and removed needs:triage Requires assignment of a team area label labels Nov 18, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 18, 2025

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 18, 2025

Hi @parkertimmins, I've created a changelog YAML for you.

martijnvg
martijnvg approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@parkertimmins parkertimmins merged commit 279c349 into elastic:main Nov 19, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 19, 2025

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 138265

@parkertimmins parkertimmins mentioned this pull request Nov 19, 2025
Merged
@parkertimmins
Copy link
Contributor Author

parkertimmins commented Nov 19, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.2

Questions ?

Please refer to the Backport tool documentation

parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Nov 19, 2025
@parkertimmins
Fix index.mapping.pattern_text.disable_templating not registered issue (
f549e98 
elastic#138265)

* Fix index.mapping.pattern_text.disable_templating has not been registered issue

* Update docs/changelog/138265.yaml

* gate versions that do not have pattern_text

(cherry picked from commit 279c349)
elasticsearchmachine pushed a commit that referenced this pull request Nov 19, 2025
@parkertimmins
[9.2] Fix index.mapping.pattern_text.disable_templating not registere…
5a542b0 
…d issue (#138265) (#138324)

* Fix index.mapping.pattern_text.disable_templating not registered issue (#138265)

* Fix index.mapping.pattern_text.disable_templating has not been registered issue

* Update docs/changelog/138265.yaml

* gate versions that do not have pattern_text

(cherry picked from commit 279c349)

* Copy from MatchOnlyTextRollingUpgradeIT

* gate bwc rolling upgrade test on version

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Nov 26, 2025
@parkertimmins @ncordon
Fix index.mapping.pattern_text.disable_templating not registered issue (
cf8b5b0 
elastic#138265)

* Fix index.mapping.pattern_text.disable_templating has not been registered issue

* Update docs/changelog/138265.yaml

* gate versions that do not have pattern_text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

@jordan-powers jordan-powers Awaiting requested review from jordan-powers

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.2.2 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parkertimmins @elasticsearchmachine @martijnvg