Skip to content

Conversation

@JonasKunz
Copy link
Contributor

Fixes #138399.
Looks like in #138349 this test slipped through due to randomization.

@JonasKunz JonasKunz added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL labels Nov 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added v9.3.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 21, 2025
@JonasKunz JonasKunz enabled auto-merge (squash) November 21, 2025 08:59
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fix LGTM.

Looks like in #138349 this test slipped through due to randomization.

Is that because the case of the histogram having a value count of 0 is happening very rarely in the randomization? If so, I'm wondering if it would make sense to increase the probability of that branch, or to ensure both branches are hit on every test execution.

@JonasKunz JonasKunz disabled auto-merge November 21, 2025 09:27
@JonasKunz
Copy link
Contributor Author

Is that because the case of the histogram having a value count of 0 is happening very rarely in the randomization?

No, I was just extremely lucky (or unlucky..).
The test generates a random block of length 1-100. Each histogram has roughly a 25% chance of being empty.

I noticed another test failure from #138349, which I sneaked a fix and test improvement for into this PR aswell.

@JonasKunz JonasKunz requested a review from felixbarny November 21, 2025 09:36
@JonasKunz JonasKunz enabled auto-merge (squash) November 21, 2025 09:57
@JonasKunz JonasKunz merged commit 29398f3 into elastic:main Nov 21, 2025
34 checks passed
@JonasKunz JonasKunz deleted the fix-test-componentaccess branch November 21, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ExponentialHistogramBlockTests testComponentAccess failing

4 participants