Skip to content

Fix and unmute ExponentialHistogramBlockTests.testComponentAccess. #138401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
+26 −23
Merged

Fix and unmute ExponentialHistogramBlockTests.testComponentAccess. #138401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bf4590
Fix and unmute ExponentialHistogramBlockTests.testComponentAccess.
JonasKunz Nov 21, 2025
8eb24fa
Fix ExponentialHistogramParserTests too
JonasKunz Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,6 @@ tests:
- class: org.elasticsearch.xpack.security.authc.jwt.JwtRealmAuthenticateTests
method: testJwkUpdatesByReloadWithFile
issue: https://github.com/elastic/elasticsearch/issues/138397
- class: org.elasticsearch.compute.data.ExponentialHistogramBlockTests
method: testComponentAccess
issue: https://github.com/elastic/elasticsearch/issues/138399

# Examples:
#
Expand Down
36 changes: 19 additions & 17 deletions ...c/test/java/org/elasticsearch/xpack/analytics/mapper/ExponentialHistogramParserTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,29 +35,31 @@ public class ExponentialHistogramParserTests extends ESTestCase {
private static final String TEST_FIELD_NAME = "test_field";

public void testParseRandomHistogram() throws IOException {
ExponentialHistogram histogram = ExponentialHistogramTestUtils.randomHistogram();
for (int i = 0; i < 20; i++) {
ExponentialHistogram histogram = ExponentialHistogramTestUtils.randomHistogram();

ExponentialHistogramParser.ParsedExponentialHistogram parsed;
try (XContentBuilder builder = XContentFactory.jsonBuilder()) {
ExponentialHistogramXContent.serialize(builder, histogram);
String json = Strings.toString(builder);
parsed = doParse(json);
}
ExponentialHistogramParser.ParsedExponentialHistogram parsed;
try (XContentBuilder builder = XContentFactory.jsonBuilder()) {
ExponentialHistogramXContent.serialize(builder, histogram);
String json = Strings.toString(builder);
parsed = doParse(json);
}

List<IndexWithCount> expectedPositiveBuckets = IndexWithCount.fromIterator(histogram.positiveBuckets().iterator());
List<IndexWithCount> expectedNegativeBuckets = IndexWithCount.fromIterator(histogram.negativeBuckets().iterator());
List<IndexWithCount> expectedPositiveBuckets = IndexWithCount.fromIterator(histogram.positiveBuckets().iterator());
List<IndexWithCount> expectedNegativeBuckets = IndexWithCount.fromIterator(histogram.negativeBuckets().iterator());

assertThat(parsed.scale(), equalTo(histogram.scale()));
assertThat(parsed.scale(), equalTo(histogram.scale()));

assertThat(parsed.zeroThreshold(), equalTo(histogram.zeroBucket().zeroThreshold()));
assertThat(parsed.zeroCount(), equalTo(histogram.zeroBucket().count()));
assertThat(parsed.zeroThreshold(), equalTo(histogram.zeroBucket().zeroThreshold()));
assertThat(parsed.zeroCount(), equalTo(histogram.zeroBucket().count()));

assertThat(parsed.positiveBuckets(), equalTo(expectedPositiveBuckets));
assertThat(parsed.negativeBuckets(), equalTo(expectedNegativeBuckets));
assertThat(parsed.positiveBuckets(), equalTo(expectedPositiveBuckets));
assertThat(parsed.negativeBuckets(), equalTo(expectedNegativeBuckets));

assertThat(parsed.sum(), equalTo(histogram.sum()));
assertThat(parsed.min(), equalTo(Double.isNaN(histogram.min()) ? null : histogram.min()));
assertThat(parsed.max(), equalTo(Double.isNaN(histogram.max()) ? null : histogram.max()));
assertThat(parsed.sum(), equalTo(histogram.valueCount() == 0 ? null : histogram.sum()));
assertThat(parsed.min(), equalTo(Double.isNaN(histogram.min()) ? null : histogram.min()));
assertThat(parsed.max(), equalTo(Double.isNaN(histogram.max()) ? null : histogram.max()));
}
}

public void testParseScaleMissing() {
Expand Down
10 changes: 7 additions & 3 deletions .../compute/src/test/java/org/elasticsearch/compute/data/ExponentialHistogramBlockTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,13 @@ public void testComponentAccess() {
}
}
case SUM -> {
assertThat(componentBlock.getValueCount(i), equalTo(1));
int valueIndex = componentBlock.getFirstValueIndex(i);
assertThat(((DoubleBlock) componentBlock).getDouble(valueIndex), equalTo(histo.sum()));
if (histo.valueCount() == 0) {
assertThat(componentBlock.isNull(i), equalTo(true));
} else {
assertThat(componentBlock.getValueCount(i), equalTo(1));
int valueIndex = componentBlock.getFirstValueIndex(i);
assertThat(((DoubleBlock) componentBlock).getDouble(valueIndex), equalTo(histo.sum()));
}
}
case COUNT -> {
assertThat(componentBlock.getValueCount(i), equalTo(1));
Expand Down