-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[GPU] Extend reflection to retrieve vector values #138503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rer$FloatScoringSupplier too
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
@ldematte How do encounter I checked Lucene code, and DefaultFlatVectorScorer$FloatScoringSupplier does NOT implement HasIndexSlice, so we will always return
So I think the changes in this PR are NOT necessary. What do you think? |
|
@ldematte Thanks for further clarifications. Sorry I was checking how Lucene99MemorySegmentFlatVectorsScorer falls back to DefaultFlatVectorScorer::getRandomVectorScorer when vectorValues is not isntance of HasIndexSlice. It makes sense to me to add it even just for tests. |
💚 Backport successful
|
…rer$FloatScoringSupplier too (elastic#138503) While running gpu:yamlRestTest tests, under some circumstances the scorer is not Lucene99MemorySegmentFloatVectorScorerSupplier, but DefaultFlatVectorScorer$FloatScoringSupplier. This PR extend reflection to support the "fast path" to access vector values to this class too.
…rer$FloatScoringSupplier too (#138503) (#138743) While running gpu:yamlRestTest tests, under some circumstances the scorer is not Lucene99MemorySegmentFloatVectorScorerSupplier, but DefaultFlatVectorScorer$FloatScoringSupplier. This PR extend reflection to support the "fast path" to access vector values to this class too.

While running gpu:yamlRestTest tests, I realized that under some circumstances the scorer is not
Lucene99MemorySegmentFloatVectorScorerSupplier, butDefaultFlatVectorScorer$FloatScoringSupplier. This PR extend reflection to support the "fast path" to access vector values to this class too.