-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL - Add field function pushing node reduce plan tests #138529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlosdelest
wants to merge
16
commits into
elastic:main
Choose a base branch
from
carlosdelest:non-issue/esql-function-loaders-pushdown-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ESQL - Add field function pushing node reduce plan tests #138529
carlosdelest
wants to merge
16
commits into
elastic:main
from
carlosdelest:non-issue/esql-function-loaders-pushdown-testing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
commented
Nov 26, 2025
|
|
||
| @ClassRule | ||
| public static ElasticsearchCluster cluster = Clusters.testCluster(spec -> spec.plugin("inference-service-test")); | ||
| public static ElasticsearchCluster cluster = Clusters.testCluster(); |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No inference needed, simplifying
| Map.of("data", List.of(expectedLoaders)), assertDataNodeSig); | ||
| } | ||
|
|
||
| private void test( |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reorganized the tests so we can check directly:
- The expected columns
- The expected field loaders per driver - we can check the field loaders for data and node_reduce drivers independently.
14 tasks
…on-loaders-pushdown-testing
…aders-pushdown-testing' into non-issue/esql-function-loaders-pushdown-testing
…on-loaders-pushdown-testing
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search Relevance/ES|QL
Search functionality in ES|QL
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
>test
Issues or PRs that are addressing/adding tests
v9.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #137679
Adds tests around pushing down functions on node_reduce tests.