ESQL: Push functions to field loads in primaries #138544
Merged
+334
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only push functions into field loads from primary indices. LOOKUP will need an entirely different infrastructure for pushing functions into field loads. Relates to elastic#137679
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
commented
Nov 24, 2025
| Map<Attribute.IdIgnoringWrapper, Attribute> addedAttrs = new HashMap<>(); | ||
| return plan.transformDown(LogicalPlan.class, p -> doRule(p, context, addedAttrs)); | ||
| Rule rule = new Rule(context, plan); | ||
| return plan.transformDown(LogicalPlan.class, rule::doRule); |
Member
Author
There was a problem hiding this comment.
We need more state for this rule so I made each run of it an object.
carlosdelest
approved these changes
Nov 25, 2025
...a/org/elasticsearch/xpack/esql/optimizer/rules/logical/local/PushExpressionsToFieldLoad.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/esql/optimizer/rules/logical/local/PushExpressionsToFieldLoad.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
nik9000
commented
Nov 25, 2025
Member
Author
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Thanks @carlosdelest !
This was referenced Nov 25, 2025
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Nov 26, 2025
Only push functions into field loads from primary indices. LOOKUP will need an entirely different infrastructure for pushing functions into field loads. Relates to elastic#137679 Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only push functions into field loads from primary indices. LOOKUP will need an entirely different infrastructure for pushing functions into field loads.
Relates to #137679