ESQL: Fix DateDiffTests suite timeout #138657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
For context, I evaluated moving the date/timezone combination tests somewhere faster (The function tests execute multiple tests per case). But different combinations (offset timezones, DST timezones, Z timezone, millis, nanos...) lead to different code paths, and I believe it's worth it having them running the full suite |
ncordon
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138617
The amount of cases on DateDiffTests (Similar to DateTruncTests) sometimes lead to a timeout. The suite takes around 10 minutes in (my) local tests, 20.000 tests, which will sometimes surpass the 20 min limit in CI