Skip to content

Improved validation message for unknown archived setting #138810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2025
Merged

Improved validation message for unknown archived setting #138810

merged 4 commits into from
Dec 1, 2025

Conversation

@mamazzol
Copy link
Contributor

@mamazzol mamazzol commented Dec 1, 2025

When validating an archived setting, the message is now clearer and refers to the guideline at https://www.elastic.co/docs/deploy-manage/upgrade/deployment-or-cluster/archived-settings

Relates to ES-13322

@mamazzol mamazzol added the :Core/Infra/Settings Settings infrastructure and APIs label Dec 1, 2025
@mamazzol mamazzol requested a review from a team as a code owner December 1, 2025 11:32
@mamazzol mamazzol added >refactoring auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 branch:8.19 labels Dec 1, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 1, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mamazzol mamazzol merged commit 074dc72 into elastic:main Dec 1, 2025
34 checks passed
@mamazzol mamazzol deleted the es-13322 branch December 1, 2025 16:12
This was referenced Dec 1, 2025
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 1, 2025

💔 Backport failed

Status Branch Result
❌ 9.1 Commit could not be cherrypicked due to conflicts
✅ 8.19
✅ 9.2

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 138810

mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Dec 1, 2025
@mamazzol
Improved validation message for unknown archived settings (elastic#13…
e629472 
…8810)
elasticsearchmachine pushed a commit that referenced this pull request Dec 1, 2025
@mamazzol
[9.2] Improved validation message for unknown archived settings (#138810
7d0ec62 
) (#138827)

* Improved validation message for unknown archived settings (#138810)

* Update ScopedSettingsTests.java
@mamazzol mamazzol mentioned this pull request Dec 2, 2025
Merged
@mamazzol
Copy link
Contributor Author

mamazzol commented Dec 2, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Questions ?

Please refer to the Backport tool documentation

mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Dec 2, 2025
@mamazzol
Improved validation message for unknown archived settings (elastic#13…
e4c9d3d 
…8810)

(cherry picked from commit 074dc72)

# Conflicts:
#	server/src/main/resources/org/elasticsearch/common/reference-docs-links.txt
@alex-spies alex-spies mentioned this pull request Dec 2, 2025
Closed
elasticsearchmachine pushed a commit that referenced this pull request Dec 2, 2025
@mamazzol
[8.19] Improved validation message for unknown archived settings (#13…
b9f8b18 
…8810) (#138826)

* Improved validation message for unknown archived settings (#138810)

* Update AbstractScopedSettings.java

* Update ScopedSettingsTests.java

* Update ScopedSettingsTests.java

* Update ScopedSettingsTests.java
mamazzol added a commit that referenced this pull request Dec 2, 2025
@mamazzol
[9.1] Improved validation message for unknown archived settings (#138810
58b539c 
) (#138875)

* Improved validation message for unknown archived settings (#138810)

(cherry picked from commit 074dc72)

# Conflicts:
#	server/src/main/resources/org/elasticsearch/common/reference-docs-links.txt

* Update ScopedSettingsTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdconrad jdconrad jdconrad approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Settings Settings infrastructure and APIs >refactoring Team:Core/Infra Meta label for core/infra team v8.19.9 v9.1.9 v9.2.3 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mamazzol @elasticsearchmachine @jdconrad