Skip to content

Conversation

@mamazzol
Copy link
Contributor

@mamazzol mamazzol commented Dec 2, 2025

Change the assertion on the test to remove the version query parameter that might cause issues in the future.

Addresses #138880

@mamazzol mamazzol requested a review from a team December 2, 2025 10:41
@mamazzol mamazzol added >bug :Core/Infra/Settings Settings infrastructure and APIs auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 labels Dec 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @mamazzol, I've created a changelog YAML for you.

@mosche mosche added >test Issues or PRs that are addressing/adding tests and removed >bug labels Dec 2, 2025
@mosche
Copy link
Contributor

mosche commented Dec 2, 2025

Only use the >bug label if something should show up in the release notes. This only affects tests and also wasn't ever included in a release.

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mamazzol mamazzol merged commit 38d1de3 into elastic:main Dec 2, 2025
34 checks passed
@mamazzol mamazzol deleted the fix-message-version branch December 2, 2025 16:26
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1 Commit could not be cherrypicked due to conflicts
9.2 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 138874

@mamazzol
Copy link
Contributor Author

mamazzol commented Dec 2, 2025

💚 All backports created successfully

Status Branch Result
9.2
9.1

Questions ?

Please refer to the Backport tool documentation

mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Dec 2, 2025
Change the assertion on the test to remove the version query parameter that might cause issues in the future.

(cherry picked from commit 38d1de3)

# Conflicts:
#	server/src/test/java/org/elasticsearch/common/settings/ScopedSettingsTests.java
mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Dec 2, 2025
Change the assertion on the test to remove the version query parameter that might cause issues in the future.

(cherry picked from commit 38d1de3)

# Conflicts:
#	server/src/test/java/org/elasticsearch/common/settings/ScopedSettingsTests.java
elasticsearchmachine pushed a commit that referenced this pull request Dec 3, 2025
Change the assertion on the test to remove the version query parameter that might cause issues in the future.

(cherry picked from commit 38d1de3)

# Conflicts:
#	server/src/test/java/org/elasticsearch/common/settings/ScopedSettingsTests.java
elasticsearchmachine pushed a commit that referenced this pull request Dec 3, 2025
Change the assertion on the test to remove the version query parameter that might cause issues in the future.

(cherry picked from commit 38d1de3)

# Conflicts:
#	server/src/test/java/org/elasticsearch/common/settings/ScopedSettingsTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v9.1.9 v9.2.3 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants