Speed up LeafCollector#setScorer in TopHitsAggregator #138883
Merged
+50
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Search Relevance/Search
elasticsearchmachine
added
v9.2.3
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @iverase, I've created a changelog YAML for you. |
benwtrent
approved these changes
Dec 2, 2025
iverase
added
the
auto-backport
Collaborator
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Dec 2, 2025
this commit introduce a wrapper for the Scorable that is shared by all the buckets so we only need to change it in one place when present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a performance bug reported in this discuss issue.
In lucene 10.3 there was this change to speed up must not queries. The change has the side effect that we might be calling
LeafCollector#setScorermany more times than before. This is probably ok because it is expected to be a cheap method.TopHitsAggregator contains an implementation of
LeafCollector#setScorerthat can be expensive if the aggregator is part of a multi-bucket aggregator. Whenever we set the scorer we are looping over all buckets to set the scorer.Therefore, this commit proposes to introduce a wrapper for the Scorable that is shared by all the buckets so we only need to change it in one place when present.