Use appropriate rerank code path for validation call#149202
Conversation
This commit introduces a RerankServiceIntegrationValidator class to be used when validating rerank endpoints that support the new code path, which calls rerankInfer() instead of infer(). Services that do not support the new code path continue to use SimpleServiceIntegrationValidator, which calls infer(). This commit also renames CustomServiceIntegrationValidator to CustomServiceRerankIntegrationValidator and calls rerankInfer() there, since the Custom service has been converted to the new code path. Other changes: - Extract the common logic to wrap the listener for a validation call to the ServiceIntegrationValidator interface
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
|
Hi @DonalEvans, I've created a changelog YAML for you. |
🔍 Preview links for changed docs⏳ Building and deploying preview... View progress This comment will be updated with preview links when the build is complete. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
|
@elasticmachine test this please |
There was a problem hiding this comment.
I verified the fix end to end using cloud-deploy and qaf. Thanks for the fix.
PUT _inference/rerank/test
{
"service": "elastic",
"service_settings": {
"model_id": "jina-reranker-v2-base-multilingual"
}
}
POST _inference/test
{
"input": [
"Carson City is the capital city of the American state of Nevada.",
"The Commonwealth of the Northern Mariana Islands is a group of islands in the Pacific Ocean. Its capital is Saipan.",
"Washington, D.C. (also known as simply Washington or D.C., and officially as the District of Columbia) is the capital of the United States. It is a federal district.",
"Capitalization or capitalisation in English grammar is the use of a capital letter at the start of a word. English usage varies from capitalization in other languages."
],
"query": "What is the capital of the United States?"
}
|
@elasticmachine run Elasticsearch Serverless Checks |
|
This PR has been labeled To resolve this blocker:
Optional — narrow the scope with If the bug was introduced in a specific commit, add the following line to this PR's description: This tells the promotion check that builds predating this commit are unaffected and should not be blocked. For the commit SHA, both the short (7-character) and full (40-character) SHA are accepted. For more information, see the Promotion Blocker documentation. |
This commit introduces a RerankServiceIntegrationValidator class to be used when validating rerank endpoints that support the new code path, which calls rerankInfer() instead of infer(). Services that do not support the new code path continue to use SimpleServiceIntegrationValidator, which calls infer().
This commit also renames CustomServiceIntegrationValidator to CustomServiceRerankIntegrationValidator and calls rerankInfer() there, since the Custom service has been converted to the new code path.
Other changes:
the ServiceIntegrationValidator interface